-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(example): r/mouss
#3472
base: master
Are you sure you want to change the base?
feat(example): r/mouss
#3472
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
} | ||
|
||
func isUser(addr std.Address) bool { | ||
return !isAuthorized(addr) && !contains(profile.Followers, addr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the if condition be checking the exacte opposite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use isUser
to check if follower is not admin address or if the follower exist already in the list of followers. i still working on ,I think it's could be a good feature to follow and be followed by other users.
func writeProfile to method (p Profile)Render
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR; check my comments and resolve them, and we can move forward :)
On top of this, I suggest you remove the string builder for rendering and simply add a var out string
Co-authored-by: Leon Hudak <[email protected]>
Co-authored-by: Leon Hudak <[email protected]>
Co-authored-by: Leon Hudak <[email protected]>
Co-authored-by: Leon Hudak <[email protected]>
Removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry to go at this again; can you please check out the new code in r/leon/config
, and use it that way? After this we can merge.
Hi Gnomes ,
This is my home page. it was difficult to be creative 😅 , so i did what i can do
Home :
I put some informations about me
World kitchen :
I'm passionate about cooking, so I've set up a page for those who want to share their national culinary specialties or just their favorite recipes, since there are so many nationalities in
gno
community.feel free to add your recipes ;)
@leohhhn