Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(example): r/mouss #3472

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

feat(example): r/mouss #3472

wants to merge 28 commits into from

Conversation

mous1985
Copy link
Contributor

@mous1985 mous1985 commented Jan 9, 2025

Hi Gnomes ,
This is my home page. it was difficult to be creative 😅 , so i did what i can do

Home :

I put some informations about me

Screenshot 2025-01-09 at 21 14 20

World kitchen :

I'm passionate about cooking, so I've set up a page for those who want to share their national culinary specialties or just their favorite recipes, since there are so many nationalities in gno community.

Screenshot 2025-01-09 at 21 22 54

feel free to add your recipes ;)

Screenshot 2025-01-09 at 21 35 17

@leohhhn

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jan 9, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 9, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details (checked by @thehowl)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: mous1985/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🔴 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

@mous1985 mous1985 changed the title Home page feat: Home page Jan 9, 2025
examples/gno.land/r/mouss/home/home.gno Outdated Show resolved Hide resolved
}

func isUser(addr std.Address) bool {
return !isAuthorized(addr) && !contains(profile.Followers, addr)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the if condition be checking the exacte opposite?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use isUser to check if follower is not admin address or if the follower exist already in the list of followers. i still working on ,I think it's could be a good feature to follow and be followed by other users.

examples/gno.land/r/mouss/home/home.gno Outdated Show resolved Hide resolved
examples/gno.land/r/mouss/home/home.gno Outdated Show resolved Hide resolved
@mous1985 mous1985 changed the title feat: Home page feat(example): r/mouss Jan 10, 2025
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR; check my comments and resolve them, and we can move forward :)

On top of this, I suggest you remove the string builder for rendering and simply add a var out string

examples/gno.land/r/mouss/config/config.gno Outdated Show resolved Hide resolved
examples/gno.land/r/mouss/config/config.gno Outdated Show resolved Hide resolved
examples/gno.land/r/mouss/home/home.gno Outdated Show resolved Hide resolved
examples/gno.land/r/mouss/home/home.gno Outdated Show resolved Hide resolved
examples/gno.land/r/mouss/home/home.gno Outdated Show resolved Hide resolved
examples/gno.land/r/mouss/home/home.gno Outdated Show resolved Hide resolved
examples/gno.land/r/mouss/home/home.gno Outdated Show resolved Hide resolved
examples/gno.land/r/mouss/home/home.gno Show resolved Hide resolved
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 21, 2025
@leohhhn leohhhn removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 21, 2025
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 21, 2025
@jefft0 jefft0 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 22, 2025
@jefft0
Copy link
Contributor

jefft0 commented Jan 22, 2025

Removed the review/triage-pending label because this PR was reviewed by core dev moul.

@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 22, 2025
@jefft0 jefft0 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 24, 2025
@Gno2D2 Gno2D2 requested a review from a team January 24, 2025 15:47
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry to go at this again; can you please check out the new code in r/leon/config, and use it that way? After this we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants